Skip to content

Use gitoxide in get_status #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025

Conversation

cruessler
Copy link
Collaborator

@cruessler cruessler commented Jun 29, 2025

Update 2025-07-06

I’ve been using this branch daily for the last week. I found one issue that I’ve addressed in a separate commit. I think it’s now ready for review!

Initial description

This is a draft PR. I think that, at this point, most of the initial work of porting is done. I’m going to be using this branch as my daily driver throughout the week to find any issues there might still be left. I’m planning on marking it as ready for review at the end of the week.

This PR changes asyncgit::sync::get_status to use gitoxide. As a side-effect, it lets gitoxide handle reading status.showUntrackedFiles. The resulting behaviour, with respect to status.showUntrackedFiles, is closer to what git does than it was before this PR. I’ve updated 2 tests according to the new behaviour.

@cruessler cruessler force-pushed the use-gitoxide-for-status branch from 2916a78 to 1b3694b Compare June 29, 2025 15:06
With this change, when `get_status` is run in a sub-directory, it also
returns matches in sub-directories that don’t share a prefix with the
sub-directory it is being run in.
Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions and nits, other looks good to go to me

@cruessler
Copy link
Collaborator Author

just a few questions and nits, other looks good to go to me

Great suggestions! I’ve added them as items to the tracking issue to unblock this PR. Also, I’ve already implemented one of them. :-)

@cruessler
Copy link
Collaborator Author

@extrawurst This PR is ready from my side! Do you want further changes before it is merged?

@extrawurst extrawurst enabled auto-merge (squash) July 27, 2025 15:20
@extrawurst
Copy link
Collaborator

@cruessler no sorry for the delay! looks good to me! 🥳

@extrawurst extrawurst merged commit 6685f9a into gitui-org:master Jul 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants