-
-
Notifications
You must be signed in to change notification settings - Fork 636
Use gitoxide
in get_status
#2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gitoxide
in get_status
#2673
Conversation
2916a78
to
1b3694b
Compare
With this change, when `get_status` is run in a sub-directory, it also returns matches in sub-directories that don’t share a prefix with the sub-directory it is being run in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few questions and nits, other looks good to go to me
Great suggestions! I’ve added them as items to the tracking issue to unblock this PR. Also, I’ve already implemented one of them. :-) |
@extrawurst This PR is ready from my side! Do you want further changes before it is merged? |
@cruessler no sorry for the delay! looks good to me! 🥳 |
Update 2025-07-06
I’ve been using this branch daily for the last week. I found one issue that I’ve addressed in a separate commit. I think it’s now ready for review!
Initial description
This is a draft PR. I think that, at this point, most of the initial work of porting is done. I’m going to be using this branch as my daily driver throughout the week to find any issues there might still be left. I’m planning on marking it as ready for review at the end of the week.
This PR changes
asyncgit::sync::get_status
to usegitoxide
. As a side-effect, it letsgitoxide
handle readingstatus.showUntrackedFiles
. The resulting behaviour, with respect tostatus.showUntrackedFiles
, is closer to what git does than it was before this PR. I’ve updated 2 tests according to the new behaviour.